chia7712 commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1511828525
##########
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala:
##########
@@ -72,7 +71,7 @@ import scala.annotation.nowarn
import scala.collection.mutable
import scala.jdk.CollectionConverters._
-object AuthorizerIntegrationTest {
+object AbstractAuthorizerIntegrationTest {
Review Comment:
ditto
##########
core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala:
##########
@@ -23,15 +23,17 @@ import org.apache.kafka.common.{KafkaException,
TopicPartition}
import org.apache.kafka.common.errors.SaslAuthenticationException
import org.junit.jupiter.api.{AfterEach, BeforeEach, Test, TestInfo}
import org.junit.jupiter.api.Assertions._
-import kafka.admin.ConsumerGroupCommand.{ConsumerGroupCommandOptions,
ConsumerGroupService}
import kafka.server.KafkaConfig
import kafka.utils.{JaasTestUtils, TestUtils}
import kafka.zk.ConfigEntityChangeNotificationZNode
import org.apache.kafka.common.security.auth.SecurityProtocol
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.ValueSource
-class SaslClientsWithInvalidCredentialsTest extends IntegrationTestHarness
with SaslSetup {
+abstract class AbstractSaslTest extends IntegrationTestHarness with SaslSetup {
Review Comment:
it would be better to have a separate file
##########
core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala:
##########
@@ -23,15 +23,17 @@ import org.apache.kafka.common.{KafkaException,
TopicPartition}
import org.apache.kafka.common.errors.SaslAuthenticationException
import org.junit.jupiter.api.{AfterEach, BeforeEach, Test, TestInfo}
import org.junit.jupiter.api.Assertions._
-import kafka.admin.ConsumerGroupCommand.{ConsumerGroupCommandOptions,
ConsumerGroupService}
import kafka.server.KafkaConfig
import kafka.utils.{JaasTestUtils, TestUtils}
import kafka.zk.ConfigEntityChangeNotificationZNode
import org.apache.kafka.common.security.auth.SecurityProtocol
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.ValueSource
-class SaslClientsWithInvalidCredentialsTest extends IntegrationTestHarness
with SaslSetup {
+abstract class AbstractSaslTest extends IntegrationTestHarness with SaslSetup {
Review Comment:
Also, it is worthy of having comment to explain the usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
