appchemist commented on PR #15245:
URL: https://github.com/apache/kafka/pull/15245#issuecomment-1976754065
@chia7712 Thanks for review!
`controlPlaneRequestProcessor` in `BrokerServer` isn't initialized.
The `controlPlaneRequestProcessor` is only referenced within the `shutdown`
method.
```
if (controlPlaneRequestProcessor != null)
CoreUtils.swallow(controlPlaneRequestProcessor.close(), this) // but this
line is never called, because controlPlaneRequestProcessor is always null
```
It seems likely that `BrokerServer` was built upon the `KafkaServer`
codebase.(https://github.com/apache/kafka/pull/10113)
`KafkaServer`, using Zookeeper, separates controlPlane and dataPlane to
implement
[KIP-291](https://cwiki.apache.org/confluence/display/KAFKA/KIP-291%3A+Separating+controller+connections+and+requests+from+the+data+plane)
In KRaft, the roles of DataPlane and ControlPlane in `KafkaServer` seem to
be divided into `BrokerServer` and `ControllerServer`.
It appears that the initial implementation of `BrokerServer` initialized and
used the `controlPlaneRequestProcessor`, but it seems to have been removed,
except for the code used in the `shutdown` method, through subsequent
modifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
