philipnee commented on PR #15437:
URL: https://github.com/apache/kafka/pull/15437#issuecomment-1973537076
Hey thanks for the PR - I notice a subtle thing here: Seems like we never
null check interceptors in the async consumer. Can `interceptors` ever be
null?
```
try {
Timer requestTimer = time.timer(timeout.toMillis());
// Commit with a timer to control how long the request should be
retried until it
// gets a successful response or non-retriable error.
CompletableFuture<Void> commitFuture = commit(offsets, true,
Optional.of(timeout.toMillis()));
ConsumerUtils.getResult(commitFuture, requestTimer);
-> interceptors.onCommit(offsets);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
