mjsax commented on code in PR #14448: URL: https://github.com/apache/kafka/pull/14448#discussion_r1508427425
########## .github/workflows/codesee-arch-diagram.yml: ########## @@ -0,0 +1,23 @@ +# This workflow was added by CodeSee. Learn more at https://codesee.io/ Review Comment: I don't think this file belongs to this PR. Seems the tool you are using added it automatically... ########## docs/streams/developer-guide/config-streams.html: ########## @@ -91,6 +91,7 @@ <li><a class="reference internal" href="#rocksdb-config-setter" id="id20">rocksdb.config.setter</a></li> <li><a class="reference internal" href="#state-dir" id="id14">state.dir</a></li> <li><a class="reference internal" href="#topology-optimization" id="id31">topology.optimization</a></li> + <li><a class="reference internal" href="#windowed-inner-class-serde" id="id38">windowed.inner.class.serde</a></li> Review Comment: As pointed out on the other PR. I think we should not add this config to the docs, but rather deprecate it similar to `window.size` via the KIP you started. ########## docs/streams/developer-guide/config-streams.html: ########## @@ -300,14 +306,20 @@ <h4><a class="toc-backref" href="#id23">num.standby.replicas</a><a class="header set by the user or all serdes must be passed in explicitly (see also default.key.serde).</td> <td><code class="docutils literal"><span class="pre">null</span></code></td> </tr> - <tr class="row-even"><td>default.windowed.key.serde.inner</td> + <tr class="row-even"><td>default.windowed.key.serde.inner (Deprecated. Use windowed.inner.class.serde instead.)</td> <td>Medium</td> - <td colspan="2">Default serializer/deserializer for the inner class of windowed keys, implementing the <code class="docutils literal"><span class="pre">Serde</span></code> interface.</td> +<<<<<<< HEAD Review Comment: Conflict not resolve correctly. ########## docs/streams/developer-guide/config-streams.html: ########## @@ -257,7 +258,12 @@ <h4><a class="toc-backref" href="#id23">num.standby.replicas</a><a class="header <td colspan="2">The maximum number of records to buffer per partition.</td> <td><code class="docutils literal"><span class="pre">1000</span></code></td> </tr> - <tr class="row-even"><td>cache.max.bytes.buffering</td> + <tr class="row-even"><td>statestore.cache.max.bytes</td> + <td>Medium</td> + <td colspan="2">Maximum number of memory bytes to be used for record caches across all threads. Note that at the debug level you can use <code>cache.size</code> to monitor the actual size of the Kafka Streams cache.</td> + <td>10485760</td> + </tr> + <tr class="row-even"><td>cache.max.bytes.buffering (Deprecated. Use cache.max.bytes instead.)</td> Review Comment: even/odd issue... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
