dajac commented on code in PR #15442:
URL: https://github.com/apache/kafka/pull/15442#discussion_r1507837970
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -474,6 +474,8 @@ public CoordinatorResult<OffsetCommitResponseData, Record>
commitOffset(
final List<Record> records = new ArrayList<>();
final long currentTimeMs = time.milliseconds();
final OptionalLong expireTimestampMs =
expireTimestampMs(request.retentionTimeMs(), currentTimeMs);
+ groupMetadataManager.maybeUpgradeEmptyGroup(group.groupId(), records,
true);
+ final int initialRecordsSize = records.size();
Review Comment:
My question was more about the `maybeUpgradeEmptyGroup` called here. Why do
we need it? This seems to be orthogonal to the offset metadata manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
