kirktrue commented on code in PR #15438:
URL: https://github.com/apache/kafka/pull/15438#discussion_r1506924671
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1017,11 +1016,10 @@ public Map<String, List<PartitionInfo>>
listTopics(Duration timeout) {
throw new TimeoutException();
}
- final TopicMetadataApplicationEvent topicMetadataApplicationEvent =
- new TopicMetadataApplicationEvent(timeout.toMillis());
-
wakeupTrigger.setActiveTask(topicMetadataApplicationEvent.future());
+ final TopicMetadataEvent topicMetadataEvent = new
TopicMetadataEvent(Optional.empty(), timeout.toMillis());
+ wakeupTrigger.setActiveTask(topicMetadataEvent.future());
Review Comment:
Done.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -142,40 +143,40 @@ private void process(final PollApplicationEvent event) {
requestManagers.heartbeatRequestManager.ifPresent(hrm ->
hrm.resetPollTimer(event.pollTimeMs()));
}
- private void process(final AsyncCommitApplicationEvent event) {
+ private void process(final AsyncCommitEvent event) {
CommitRequestManager manager =
requestManagers.commitRequestManager.get();
- CompletableFuture<Void> commitResult =
manager.commitAsync(event.offsets());
- event.chain(commitResult);
+ CompletableFuture<Void> future = manager.commitAsync(event.offsets());
+ chain(future, event.future());
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
