ijuma commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1499780993
##########
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##########
@@ -16,22 +16,36 @@
*/
package org.apache.kafka.streams.scala.kstream
-import org.apache.kafka.streams.kstream.internals.StreamJoinedInternal
+import org.apache.kafka.streams.kstream.internals.{InternalStreamsBuilder,
StreamJoinedInternal}
+import org.apache.kafka.streams.processor.internals.InternalTopologyBuilder
import org.apache.kafka.streams.scala.serialization.Serdes
import org.apache.kafka.streams.scala.serialization.Serdes._
import org.apache.kafka.streams.state.Stores
+import org.easymock.EasyMock
+import org.easymock.EasyMock.{createMock, replay}
import org.junit.jupiter.api.Assertions.assertEquals
-import org.junit.jupiter.api.Test
+import org.junit.jupiter.api.{BeforeEach, Test}
import java.time.Duration
class StreamJoinedTest {
+ val builder: InternalStreamsBuilder =
createMock(classOf[InternalStreamsBuilder])
+ val topoBuilder: InternalTopologyBuilder =
createMock(classOf[InternalTopologyBuilder])
+
+ @BeforeEach
+ def before(): Unit = {
+ EasyMock.expect(builder.internalTopologyBuilder()).andReturn(topoBuilder);
Review Comment:
We should be using `mockito` for new tests. A large number of tests have
been converted (a huge amount of work) - this is adding more conversion work.
cc @divijvaidya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
