jolshan commented on code in PR #15359:
URL: https://github.com/apache/kafka/pull/15359#discussion_r1488762961
##########
metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java:
##########
@@ -120,9 +120,7 @@ Optional<CompletedReassignment>
maybeCompleteReassignment(List<Integer> targetIs
}
if (newTargetReplicas.isEmpty()) return Optional.empty();
}
- for (int replica : adding) {
- if (!newTargetIsr.contains(replica)) return Optional.empty();
Review Comment:
Are you sure?
```
newTargetReplicas = new ArrayList<>(replicas.size());
for (int replica : replicas) {
if (!removing.contains(replica)) {
newTargetReplicas.add(replica);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
