lianetm commented on code in PR #15275:
URL: https://github.com/apache/kafka/pull/15275#discussion_r1486257781
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -1392,4 +1356,16 @@ public void registerStateListener(MemberStateListener
listener) {
}
this.stateUpdatesListeners.add(listener);
}
+
+ /**
+ * If either a new target assignment or new metadata is available that we
have not yet attempted
+ * to reconcile, and we are currently in state RECONCILING, trigger
reconciliation.
+ */
+ @Override
+ public PollResult poll(final long currentTimeMs) {
+ if (state == MemberState.RECONCILING) {
+ maybeReconcile();
Review Comment:
Just for the record you are both right, us requesting metadata updates from
the reconciliation, is only setting a flag in the metadata object indicating
that it needs a full update, but effectively a single metadata request is going
to be issued when that flag is on, on the next network client poll. Here btw,
we just have a related jira for a potential future improvement, regarding
partial metadata updates when reconciling
(https://issues.apache.org/jira/browse/KAFKA-15847), since right now we request
it for all topics, even if we only need the ones involved in the assignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
