msn-tldr commented on code in PR #15323:
URL: https://github.com/apache/kafka/pull/15323#discussion_r1484638827
##########
clients/src/main/java/org/apache/kafka/clients/MetadataCache.java:
##########
@@ -52,7 +52,7 @@ public class MetadataCache {
private final Map<TopicPartition, PartitionMetadata> metadataByPartition;
private final Map<String, Uuid> topicIds;
private final Map<Uuid, String> topicNames;
- private Cluster clusterInstance;
+ private InternalCluster clusterInstance;
Review Comment:
> We should confirm though.
I don't see it being used mutably in code. I see historically, it was made
mutable to support deletion/updates within cache, but the deletion/update code
has since been removed. As far i can see, read-only semantic. So i have treated
`MetadataCache` as immutable cache, made its internal data structures
unmodifiable and updated the javadoc.
All clients test pass locally, hopefully Jenkins signal is green too 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
