rreddy-22 commented on code in PR #15150:
URL: https://github.com/apache/kafka/pull/15150#discussion_r1484628868
##########
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##########
@@ -2811,6 +2811,72 @@ public void testListConsumerGroupsWithStates() throws
Exception {
}
}
+ @Test
+ public void testListConsumerGroupsWithTypes() throws Exception {
+ try (AdminClientUnitTestEnv env = new
AdminClientUnitTestEnv(mockCluster(1, 0))) {
+ env.kafkaClient().setNodeApiVersions(NodeApiVersions.create());
+
+ // Test with a specific state filter but no type filter in list
consumer group options.
+
env.kafkaClient().prepareResponse(prepareMetadataResponse(env.cluster(),
Errors.NONE));
+
+ env.kafkaClient().prepareResponseFrom(
+ request -> request instanceof ListGroupsRequest &&
+ !((ListGroupsRequest)
request).data().statesFilter().isEmpty() &&
+ ((ListGroupsRequest)
request).data().typesFilter().isEmpty(),
Review Comment:
haha okay, I actually started off by adding it to the unsupported version
response method before getting the comments, it's honestly weird that the other
tests don't validate anything lol, I had this urge to change the state tests
also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
