rreddy-22 commented on code in PR #15150:
URL: https://github.com/apache/kafka/pull/15150#discussion_r1482012622
##########
clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupListing.java:
##########
@@ -68,48 +97,44 @@ public boolean isSimpleConsumerGroup() {
}
/**
- * Consumer Group state
+ * Consumer Group state.
*/
public Optional<ConsumerGroupState> state() {
return state;
}
+ /**
+ * The type of the consumer group.
+ *
+ * @return An Optional containing the type, if available.
+ */
+ public Optional<GroupType> groupType() {
+ return groupType;
+ }
+
@Override
public String toString() {
return "(" +
"groupId='" + groupId + '\'' +
", isSimpleConsumerGroup=" + isSimpleConsumerGroup +
", state=" + state +
+ ", groupType=" + groupType +
')';
}
@Override
public int hashCode() {
- return Objects.hash(groupId, isSimpleConsumerGroup, state);
+ return Objects.hash(groupId, isSimpleConsumerGroup(), state,
groupType);
}
@Override
- public boolean equals(Object obj) {
- if (this == obj)
- return true;
- if (obj == null)
- return false;
- if (getClass() != obj.getClass())
- return false;
- ConsumerGroupListing other = (ConsumerGroupListing) obj;
- if (groupId == null) {
Review Comment:
makes sense thanks for the catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
