mjsax commented on code in PR #14360:
URL: https://github.com/apache/kafka/pull/14360#discussion_r1473438104
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -1010,6 +1016,18 @@ <h4><a class="toc-backref"
href="#id31">topology.optimization</a><a class="heade
</p>
</div></blockquote>
</div>
+ <div class="section" id="windowed.inner.class.serde">
+ <h4><a class="toc-backref" href="#id31">windowed.inner.class.serde</a><a
class="headerlink" href="#windowed.inner.class.serde" title="Permalink to this
headline"></a></h4>
+ <blockquote>
+ <div>
+ <p>
+ Serde for the inner class of a windowed record. Must implement the
org.apache.kafka.common.serialization.Serde interface.
+ </p>
+ <p>
+ Note that setting this config in KafkaStreams application would
result in an error as it is meant to be used only from Plain consumer client.
Review Comment:
Thanks Sophie.
> Note that this config is only used by plain consumer/producer clients
For this case, why are we documenting is in KS docs -- should it not be in
clients docs? (Also, this applies to `window.size.ms` introduced in 2.8 via
https://cwiki.apache.org/confluence/display/KAFKA/KIP-659%3A+Improve+TimeWindowedDeserializer+and+TimeWindowedSerde+to+handle+window+size,
right, but not to `windowed.inner.serde.class` which is a KS config added in
3.0 via
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=177047930
In the end, KS module provides the window-serdes and thus it does not make
sense to add `window.size.ms` to `ClientConfig` -- especially, as you pointed
out, because is only necessary for console consumer.
Thus, while `StreamsConfig#WINDOW_SIZE_MS_CONFIG` must exist as a variable
name, I am wondering if it's actually correct that we added it as a
StreamsConfig, ie, via `define(...)`? Mabye we should do a small KIP and remove
it? -- For use, we should not mention `window.size.ms` in KS docs on the
web-page (at least not for "top level config" -- we should either add it to a
"windowed serde" section, or to (console) consumer config section where it
belong to)?
`window.inner.serde.class` is a KS config and should just be documented in
the regular way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
