cmccabe commented on code in PR #15262:
URL: https://github.com/apache/kafka/pull/15262#discussion_r1473174695
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2586,7 +2586,7 @@ class ReplicaManager(val config: KafkaConfig,
// retrieve the UUID here because logManager.handleLogDirFailure handler
removes it
val uuid = logManager.directoryId(dir)
logManager.handleLogDirFailure(dir)
- if (dir == config.metadataLogDir) {
+ if (dir == new File(config.metadataLogDir).getAbsolutePath &&
(zkClient.isEmpty || config.migrationEnabled)) {
Review Comment:
This is not quite the correct check... you should check
`config.processRoles` (probably `config.processRoles.isNotEmpty ||
config.migrationEnabled`
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2586,7 +2586,7 @@ class ReplicaManager(val config: KafkaConfig,
// retrieve the UUID here because logManager.handleLogDirFailure handler
removes it
val uuid = logManager.directoryId(dir)
logManager.handleLogDirFailure(dir)
- if (dir == config.metadataLogDir) {
+ if (dir == new File(config.metadataLogDir).getAbsolutePath &&
(zkClient.isEmpty || config.migrationEnabled)) {
Review Comment:
This is not quite the correct check... you should check
`config.processRoles` (probably `config.processRoles.isNotEmpty ||
config.migrationEnabled` )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
