C0urante commented on code in PR #15249:
URL: https://github.com/apache/kafka/pull/15249#discussion_r1468141005
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java:
##########
@@ -238,9 +238,6 @@ public void testBrokerCoordinator() throws Exception {
connect.kafka().stopOnlyKafka();
- connect.assertions().assertExactlyNumWorkersAreUp(NUM_WORKERS,
- "Group of workers did not remain the same after broker
shutdown");
-
Review Comment:
This check doesn't seem necessary. A distributed Connect worker does become
unavailable when the underlying Kafka cluster is unavailable, and the existing
check (that a request to `GET /` is successful) doesn't really prove much about
worker liveness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
