dajac commented on code in PR #15176:
URL: https://github.com/apache/kafka/pull/15176#discussion_r1453039755
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1132,36 +1123,31 @@ class ReplicaManager(val config: KafkaConfig,
* @param transactionalId the transactional id for the transaction
* @param producerId the producer id for the producer writing
to the transaction
* @param producerEpoch the epoch of the producer writing to the
transaction
- * @param requestLocal container for the stateful instances
scoped to this request -- this must correspond to the
- * thread calling this method
* @param callback the method to execute once the
verification is either completed or returns an error
*
* When the verification returns, the callback will be supplied the errors
per topic partition if there were errors.
* The callback will also be supplied the verification guards per partition
if they exist. It is possible to have an
* error and a verification guard for a topic partition if the topic
partition was unable to be verified by the transaction
- * coordinator. Transaction coordinator errors are mapped to append-friendly
errors. The callback is wrapped so that it
- * is scheduled on a request handler thread. There, it should be called with
that request handler thread's thread local and
- * not the one supplied to this method.
+ * coordinator. Transaction coordinator errors are mapped to append-friendly
errors.
*/
def maybeStartTransactionVerificationForPartitions(
topicPartitionBatchInfo: Map[TopicPartition, Int],
transactionalId: String,
producerId: Long,
producerEpoch: Short,
- requestLocal: RequestLocal,
- callback: (Map[TopicPartition, Errors], RequestLocal, Map[TopicPartition,
VerificationGuard]) => Unit
+ callback: mutable.Map[TopicPartition, Either[Errors, VerificationGuard]]
=> Unit
Review Comment:
This is correct. The `requestLocal` is not required within this function
though. The caller if it uses `wrapAsyncCallback` will get the correct one to
use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
