mjsax commented on code in PR #15148:
URL: https://github.com/apache/kafka/pull/15148#discussion_r1446048539
##########
clients/src/test/java/org/apache/kafka/common/requests/PushTelemetryRequestTest.java:
##########
@@ -34,4 +53,65 @@ public void testGetErrorResponse() {
assertEquals(Collections.singletonMap(Errors.CLUSTER_AUTHORIZATION_FAILED, 1),
response.errorCounts());
}
+ @ParameterizedTest
+ @EnumSource(CompressionType.class)
+ public void testMetricsDataCompression(CompressionType compressionType) {
+ MetricsData metricsData = getMetricsData();
+ PushTelemetryRequest req = getPushTelemetryRequest(metricsData,
compressionType);
+
+ ByteBuffer receivedMetricsBuffer = req.metricsData();
+ assertNotNull(receivedMetricsBuffer);
+ assertTrue(receivedMetricsBuffer.capacity() > 0);
+
+ MetricsData receivedData =
ClientTelemetryUtils.deserializeMetricsData(receivedMetricsBuffer);
+ assertEquals(metricsData, receivedData);
+ }
+
+ private PushTelemetryRequest getPushTelemetryRequest(MetricsData
metricsData, CompressionType compressionType) {
+ byte[] data = metricsData.toByteArray();
+ ByteBuffer metricsBuffer = ClientTelemetryUtils.compress(data,
compressionType);
+ if (compressionType != CompressionType.NONE) {
+ assertTrue(metricsBuffer.array().length < data.length);
+ } else {
+ assertEquals(metricsBuffer.array().length, data.length);
Review Comment:
Should we check if both arrays are the same (not just their length)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
