satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442402745
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1245,7 +1246,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private[log] def collectAbortedTransactions(startOffset: Long,
upperBoundOffset: Long): List[AbortedTxn] = {
Review Comment:
I thought these could be addressed when `UnifiedLog` is refactored and moved
to storage module.
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1245,7 +1246,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private[log] def collectAbortedTransactions(startOffset: Long,
upperBoundOffset: Long): List[AbortedTxn] = {
Review Comment:
I thought these could be addressed when `UnifiedLog` is refactored and moved
to storage module.
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -2265,11 +2268,12 @@ object UnifiedLog extends Logging {
def deleteProducerSnapshots(): Unit = {
LocalLog.maybeHandleIOException(logDirFailureChannel,
parentDir,
- s"Error while deleting producer state snapshots for $topicPartition in
dir $parentDir") {
+ s"Error while deleting producer state snapshots for $topicPartition in
dir $parentDir", {
snapshotsToDelete.foreach { snapshot =>
snapshot.deleteIfExists()
}
- }
+ return;
Review Comment:
It was expecting a return for inline declaration, it is throwing a type
mismatch error without that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
