nizhikov commented on code in PR #14867:
URL: https://github.com/apache/kafka/pull/14867#discussion_r1434240386
##########
core/src/main/scala/kafka/zk/ZkData.scala:
##########
@@ -1103,11 +1105,11 @@ object ZkData {
IsrChangeNotificationZNode.path,
ProducerIdBlockZNode.path,
LogDirEventNotificationZNode.path
- ) ++ ConfigType.all.map(ConfigEntityTypeZNode.path)
+ ) ++
JavaConverters.asScalaIteratorConverter(ConfigType.ALL.iterator()).asScala.map(ConfigEntityTypeZNode.path)
Review Comment:
Great catch. Thanks. Rewrote like you suggested.
##########
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##########
@@ -77,8 +78,9 @@ object ConfigCommand extends Logging {
val BrokerDefaultEntityName = ""
val BrokerLoggerConfigType = "broker-loggers"
- val BrokerSupportedConfigTypes = ConfigType.all :+ BrokerLoggerConfigType :+
ConfigType.ClientMetrics
- val ZkSupportedConfigTypes = Seq(ConfigType.User, ConfigType.Broker)
+ @nowarn("cat=deprecation")
+ val BrokerSupportedConfigTypes =
JavaConverters.asScalaIteratorConverter(ConfigType.ALL.iterator()).asScala.toSeq
:+ BrokerLoggerConfigType :+ ConfigType.CLIENT_METRICS
Review Comment:
Great catch. Thanks. Rewrote like you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
