[
https://issues.apache.org/jira/browse/KAFKA-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740713#comment-17740713
]
Yi-Sheng Lien commented on KAFKA-15155:
---------------------------------------
Hi [~divijvaidya] ,
I'm interested in the Kafka project and reading the [HOW TO
CONTRIBUTE.|https://kafka.apache.org/contributing]
May I take this issue as my first issue of Kafka if you don't mind?
> Follow PEP 8 best practice in Python to check if a container is empty
> ---------------------------------------------------------------------
>
> Key: KAFKA-15155
> URL: https://issues.apache.org/jira/browse/KAFKA-15155
> Project: Kafka
> Issue Type: Improvement
> Reporter: Divij Vaidya
> Priority: Trivial
> Labels: newbie
>
> *This is a good task for first time contributors to Kafka*
> At release.py Line:94 and at Line:60, we don't follow PEP 8 [1] best
> practices.
> To check if a container or sequence (string, list, tuple) is empty, use if
> not val. Do not compare its length using if len(val) == 0
> [1]
> [https://peps.python.org/pep-0008/#programming-recommendations#:~:text=if%20not%20seq]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
