cmccabe commented on code in PR #13826:
URL: https://github.com/apache/kafka/pull/13826#discussion_r1224806791
##########
core/src/main/scala/kafka/server/ControllerApis.scala:
##########
@@ -447,16 +447,9 @@ class ControllerApis(val requestChannel: RequestChannel,
requestThrottleMs =>
apiVersionRequest.getErrorResponse(requestThrottleMs,
INVALID_REQUEST.exception))
CompletableFuture.completedFuture[Unit](())
} else {
- val context = new ControllerRequestContext(request.context.header.data,
request.context.principal, OptionalLong.empty())
- controller.finalizedFeatures(context).handle { (result, exception) =>
- requestHelper.sendResponseMaybeThrottle(request, requestThrottleMs => {
- if (exception != null) {
- apiVersionRequest.getErrorResponse(requestThrottleMs, exception)
- } else {
- apiVersionManager.apiVersionResponse(requestThrottleMs,
result.featureMap().asScala.toMap, result.epoch())
- }
- })
- }
+ requestHelper.sendResponseMaybeThrottle(request,
Review Comment:
It cannot be the same as KafkaApis because this code returns a future, which
the KafkApis code does not. And the comment about authentication seems good to
keep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
