[
https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686041#comment-17686041
]
ASF GitHub Bot commented on KAFKA-14692:
----------------------------------------
mimaison commented on code in PR #487:
URL: https://github.com/apache/kafka-site/pull/487#discussion_r1100522020
##########
34/ops.html:
##########
@@ -3615,8 +3620,21 @@ <h3>Preparing for migration</h3>
<h3>Provisioning the KRaft controller quorum</h3>
<p>
Two things are needed before the migration can begin. The brokers must be
configured to support the migration and
- a KRaft controller quorum must be deployed. For the KRaft deployment,
please refer to <a href="#kraft_config">the above documentation</a>.
- The KRaft controllers should be provisioned with the latest
<code>metadata.version</code> of "3.4".
+ a KRaft controller quorum must be deployed. The KRaft controllers should
be provisioned with the same cluster ID as
+ the existing Kafka cluster. This can be found by examining one of the
"meta.properties" files in the data directories
+ of the brokers, or by running the following command.
+ </p>
+
+ <pre>
+ ./bin/zookeeper-shell.sh localhost:2181 get /cluster/id
Review Comment:
Text within `<pre>` blocks keep the padding and the final line ending. I
find the docs much more readable when we remove the spaces and avoid having a
new line at the end.
```
<pre>
./bin/zookeeper-shell.sh localhost:2181 get /cluster/id</pre>
```
This applies to all other formatted blocks in this section.
> Issues in Zookeeper to KRaft migration docs
> -------------------------------------------
>
> Key: KAFKA-14692
> URL: https://issues.apache.org/jira/browse/KAFKA-14692
> Project: Kafka
> Issue Type: Improvement
> Components: docs
> Reporter: Mickael Maison
> Assignee: David Arthur
> Priority: Major
>
> Following [https://kafka.apache.org/documentation/#kraft_zk_migration]
> 1) It completely skips the facts that the storage for the new quorum should
> be formatted using the existing cluster id.
> 2) In Provisioning the KRaft controller quorum:
> {{controller.quorum.voters=1@localhost:9093}} should be
> {{controller.quorum.voters=3000@localhost:9093}} as node.id=3000
> 3) When migrating brokers, it states:
> {code:java}
> # Don't set the IBP, KRaft uses "metadata.version" feature flag
> # inter.broker.protocol.version=3.4
> # Keep the migration enabled
> zookeeper.metadata.migration.enable=true
> # Remove ZooKeeper client configuration
> # zookeeper.connect=localhost:2181
> {code}
> However if I do that, my brokers fails to restart and print:
> {code:java}
> org.apache.kafka.common.config.ConfigException: If using
> zookeeper.metadata.migration.enable in KRaft mode, zookeeper.connect must
> also be set.
> {code}
> 4) When disabling zookeeper.metadata.migration.enable or keeping
> zookeeper.connect to get past this step, when brokers restart they print a
> lot of error messages:
> {code:java}
> org.apache.kafka.common.errors.InvalidRequestException: Received request api
> key LEADER_AND_ISR which is not enabled
> [2023-02-08 12:06:25,776] ERROR Exception while processing request from
> 192.168.1.11:9092-192.168.1.11:57210-107 (kafka.network.Processor)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
