[ 
https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141672#comment-16141672
 ] 

Randall Hauch commented on KAFKA-5756:
--------------------------------------

[~olkuznsmith], thanks for the fix. As mentioned on the PR, the code change 
looks good. 

However, this PR needs to be against the {{trunk}} branch rather than an older 
release branch. This is the case for all Apache Kafka PRs. 

To have a change backported, you simply need to ask for it in the PR and to 
mention the specific branches. If the PR is approved and the backporting is 
approved, the committer will merge the changes and backport to those branches. 
If there are any issues with backporting, the committer may ask you to create a 
specific PR against that branch.

> Synchronization issue on flush
> ------------------------------
>
>                 Key: KAFKA-5756
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5756
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 0.10.2.0
>            Reporter: Oleg Kuznetsov
>
> Access to *OffsetStorageWriter#toFlush* is not synchronized in *doFlush()* 
> method, whereas this collection can be accessed from 2 different threads:
> - *WorkerSourceTask.execute()*, finally block
> - *SourceTaskOffsetCommitter*, from periodic flush task



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to