On Thu, Mar 19 2015, Dave Kleikamp <[email protected]> wrote: > On 03/19/2015 11:11 AM, Boaz Harrosh wrote: >> On 03/19/2015 01:28 PM, Rasmus Villemoes wrote: >>> list_entry is just a wrapper for container_of, but it is arguably >>> wrong (and slightly confusing) to use it when the pointed-to struct >>> member is not a struct list_head. Use container_of directly instead. >>> >>> Signed-off-by: Rasmus Villemoes <[email protected]> >>> --- >>> Most of these predate git. If I'm the only one who has been confused >>> by this in 10 years, maybe it's not worth the churn. >>> >> >> No you are not alone here. I have seen this once as well but did not have >> the gumption to send a fix. (The sysv.h one) >> >> I totally agree with this patch. (So many of them, bread crumbs of copy/paste >> for you ;0) > > I'm sure that was the case with jfs. > >> >> Reviewed-by: Boaz Harrosh <[email protected]> > > Acked-by: Dave Kleikamp <[email protected]>
Al, any chance you'd take this through the vfs tree? Rasmus ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Jfs-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jfs-discussion
