mboapache opened a new pull request, #120: URL: https://github.com/apache/db-jdo/pull/120
- Methods should not be empty - "@Override" should be used on overriding and implementing methods - Cognitive Complexity of methods should not be too high - Array designators "[]" should be on the type, not the variable - Standard outputs should not be used directly to log anything - Throwable and Error should not be caught - "String.isEmpty()" should be used to test for emptiness - "switch" statements should have "default" clauses - Local variables should not be declared and then immediately returned or thrown - Local variables should not shadow class fields - Methods should not have too many parameters -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
