This is an automated email from the ASF dual-hosted git repository. robertlazarski pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/axis-axis2-java-rampart.git
commit c2db725a84503681f669447e348031c35bf05ce3 Author: Robert Lazarski <[email protected]> AuthorDate: Tue Jun 9 12:48:21 2026 -1000 Address Gemini review nits: enforcer comment + failIfNoTests safety net - Document why maven-enforcer requireNoRepositories uses banRepositories=false (the Shibboleth repo is required to resolve OpenSAML, which is not on Maven Central). Prevents a future "cleanup" from removing the needed repository. - Make failIfNoTests a real safety net. Surefire defaults this to false, so the previous global <failIfNoTests>false</failIfNoTests> was redundant and meant a code module whose tests vanished would pass silently. Set the property to true at the root and override it to false only in the modules that legitimately have no tests of their own (rampart-testutils, rampart-mar, rampart-trust-mar). Verified with a full clean -Papache-release verify (all 12 modules, all tests including the 9 policy samples) on JDK 25. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> --- modules/rampart-mar/pom.xml | 5 +++++ modules/rampart-testutils/pom.xml | 5 +++++ modules/rampart-trust-mar/pom.xml | 5 +++++ pom.xml | 9 ++++++++- 4 files changed, 23 insertions(+), 1 deletion(-) diff --git a/modules/rampart-mar/pom.xml b/modules/rampart-mar/pom.xml index 629f341a..99732cf6 100644 --- a/modules/rampart-mar/pom.xml +++ b/modules/rampart-mar/pom.xml @@ -34,6 +34,11 @@ <packaging>mar</packaging> <name>Rampart - Mar</name> + <properties> + <!-- Packaging module: assembles the rampart.mar, has no tests of its own. --> + <failIfNoTests>false</failIfNoTests> + </properties> + <build> <plugins> <plugin> diff --git a/modules/rampart-testutils/pom.xml b/modules/rampart-testutils/pom.xml index 820adda6..e35d9381 100644 --- a/modules/rampart-testutils/pom.xml +++ b/modules/rampart-testutils/pom.xml @@ -30,6 +30,11 @@ <artifactId>rampart-testutils</artifactId> <packaging>jar</packaging> + <properties> + <!-- This module is a test-support library with no tests of its own. --> + <failIfNoTests>false</failIfNoTests> + </properties> + <dependencies> <dependency> <groupId>org.aspectj</groupId> diff --git a/modules/rampart-trust-mar/pom.xml b/modules/rampart-trust-mar/pom.xml index 4215dd35..bf77fc41 100644 --- a/modules/rampart-trust-mar/pom.xml +++ b/modules/rampart-trust-mar/pom.xml @@ -35,6 +35,11 @@ <packaging>mar</packaging> <name>Rampart - Trust-Mar</name> + <properties> + <!-- Packaging module: assembles the rahas.mar, has no tests of its own. --> + <failIfNoTests>false</failIfNoTests> + </properties> + <build> <plugins> <plugin> diff --git a/pom.xml b/pom.xml index 6d9d9807..aa0abeb8 100644 --- a/pom.xml +++ b/pom.xml @@ -239,6 +239,10 @@ <rules> <requireNoRepositories> <message>The POM must not include repository definitions since non Apache repositories threaten the build stability.</message> + <!-- banRepositories is intentionally false: the <repositories> section + declares the Shibboleth repository, which is required to resolve the + OpenSAML artifacts (not available from Maven Central). Do not remove + that repository or set this to true. --> <banRepositories>false</banRepositories> <banPluginRepositories>true</banPluginRepositories> <!-- We still need to allow the Apache snapshot repository --> @@ -854,7 +858,10 @@ <bcprov.jdk18.version>1.84</bcprov.jdk18.version> - <failIfNoTests>false</failIfNoTests> + <!-- Fail the build if a module expected to have tests suddenly has none + (tests deleted or no longer discovered). Surefire reads this property + natively; modules that legitimately have no tests override it to false. --> + <failIfNoTests>true</failIfNoTests> <jacoco.version>0.8.15</jacoco.version> <slf4j.version>2.0.16</slf4j.version>
