Author: veithen
Date: Sat Jan 7 18:06:54 2012
New Revision: 1228689
URL: http://svn.apache.org/viewvc?rev=1228689&view=rev
Log:
AXIS-2850: Removed the inherently non thread-safe Service#getCall() method and
solved a thread safety issue involving Service#createCall(). The removed method
is part of the public API, but:
* It is deprecated since Axis 1.2.
* People generally prefer build failures or NoSuchMethodErrors over dealing
with subtle concurrency issues that only show up in production systems and that
are not reproducible.
Modified:
axis/axis1/java/trunk/axis/src/main/java/org/apache/axis/client/Service.java
Modified:
axis/axis1/java/trunk/axis/src/main/java/org/apache/axis/client/Service.java
URL:
http://svn.apache.org/viewvc/axis/axis1/java/trunk/axis/src/main/java/org/apache/axis/client/Service.java?rev=1228689&r1=1228688&r2=1228689&view=diff
==============================================================================
---
axis/axis1/java/trunk/axis/src/main/java/org/apache/axis/client/Service.java
(original)
+++
axis/axis1/java/trunk/axis/src/main/java/org/apache/axis/client/Service.java
Sat Jan 7 18:06:54 2012
@@ -83,9 +83,6 @@ public class Service implements javax.xm
private static Map cachedWSDL = new WeakHashMap();
private static boolean cachingWSDL = true;
- // The last call object
- protected Call _call = null;
-
/**
* A Hashtable mapping addresses (URLs) to Transports (objects)
*/
@@ -556,8 +553,7 @@ public class Service implements javax.xm
* @throws ServiceException If there's an error
*/
public javax.xml.rpc.Call createCall() throws ServiceException {
- _call = new org.apache.axis.client.Call(this);
- return _call;
+ return new org.apache.axis.client.Call(this);
}
/**
@@ -838,17 +834,6 @@ public class Service implements javax.xm
}
/**
- * Returns last Call object associated with this service. Note that since
- * the Service is not thread-safe, you may not get the last call object
- * that you created on this thread. please use Stub._getCall
- *
- * @deprecated please use Stub._getCall
- */
- public Call getCall() throws ServiceException {
- return _call;
- }
-
- /**
* Tells whether or not we're caching WSDL
*/
public boolean getCacheWSDL() {
