[
https://issues.apache.org/jira/browse/WW-5624?focusedWorklogId=1014148&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1014148
]
ASF GitHub Bot logged work on WW-5624:
--------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/26 02:04
Start Date: 09/Apr/26 02:04
Worklog Time Spent: 10m
Work Description: tranquac commented on PR #1657:
URL: https://github.com/apache/struts/pull/1657#issuecomment-4210972232
This PR supersedes #1651 and #1652 with a consolidated approach that
addresses the review feedback:
1. **Shared service, no duplication**: `ParameterAuthorizer` is extracted
once from `ParametersInterceptor` and shared by JSON/REST plugins (as requested
by @lukaszlenart).
2. **OGNL isolation**: `ThreadAllowlist` side effects stay in
`ParametersInterceptor` only — the shared service is OGNL-free.
3. **Backward compatible**: REST two-phase deserialization only activates
when `struts.parameters.requireAnnotations=true`. Direct deserialization
remains the default.
4. **Complete DI wiring**: All 3 levels (struts-beans.xml,
StrutsBeanSelectionProvider alias, DefaultConfiguration factory) are registered.
5. **Comprehensive tests**: 19 new tests covering authorization, rejection,
ModelDriven exemption, transition mode, depth enforcement, and null/empty
parameter guards. All 280 existing tests across core/json/rest pass.
Issue Time Tracking
-------------------
Worklog Id: (was: 1014148)
Time Spent: 1h (was: 50m)
> Request body population bypasses @StrutsParameter contract outside
> ParametersInterceptor
> ----------------------------------------------------------------------------------------
>
> Key: WW-5624
> URL: https://issues.apache.org/jira/browse/WW-5624
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - JSON, Plugin - REST
> Affects Versions: 7.1.1
> Reporter: Tran Quac
> Priority: Major
> Fix For: 7.2.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> h2. Summary
> {{@StrutsParameter}} enforcement is currently implemented in
> {{ParametersInterceptor}} for standard request parameter binding, but
> request-body based binders in some plugins bypass that authorization model
> and populate action/model objects directly.
> This creates inconsistent behavior between URL/form parameters and JSON/XML
> request bodies, and may allow mass assignment of properties that would
> normally be rejected by {{ParametersInterceptor}}.
> h2. Affected areas currently identified
> * JSON plugin:
> {{JSONPopulator.populateObject()}} sets properties via direct reflection and
> does not follow the full {{@StrutsParameter}} authorization rules.
> * REST plugin:
> {{JacksonJsonHandler.toObject()}} updates target objects directly via Jackson
> and does not follow the full {{@StrutsParameter}} authorization rules.
> h2. Problem scope
> The issue is broader than checking whether a setter is annotated. The current
> core contract in {{ParametersInterceptor}} also includes:
> * permitted nesting depth
> * authorization based on the exposed root member
> * ModelDriven handling
> * transition mode semantics
> * related allowlisting behavior
> Any request-body binding implementation should align with that same contract,
> otherwise Struts applies different security rules depending on how input
> reaches the action/model.
> h2. Expected direction
> Instead of implementing separate partial checks in each plugin, Struts should
> reuse or extract the shared parameter-binding authorization logic from
> {{ParametersInterceptor}} and apply it consistently across request-body
> binders.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
