zhang-arvin opened a new pull request, #4502:
URL: https://github.com/apache/streampark/pull/4502

   ## What problem does this PR solve?
   
   Fixes #3617: The memory sizes configuration in Application Conf (e.g., 
`jobmanager.memory.process.size`, `taskmanager.memory.process.size`) was not 
taking effect when submitting Flink jobs in Yarn mode.
   
   ## Root Cause
   
   In `FlinkClientTrait.prepareConfig()`, the `appProperties()` from the 
Application Conf (parsed with `flink.property.` prefix) were never applied to 
the Flink configuration. While `submitRequest.properties()` (dynamic properties 
from the web UI) were correctly passed as `-D` flags via `buildCliArgs()`, the 
Application Conf properties were silently ignored.
   
   ## Fix
   
   Added `applyAppProperties()` method in `FlinkClientTrait` that applies all 
`appProperties()` from the Application Conf to the Flink configuration. This 
method is called in `prepareConfig()` after `applyEnvProperties()`, ensuring 
that all Flink configuration properties set in the Application Conf are 
properly propagated to the submit request.
   
   ## Changes
   
   - **streampark-flink-client-core**: Added `applyAppProperties()` method to 
`FlinkClientTrait` and called it in `prepareConfig()`
   - **streampark-flink-client-core test**: Added 3 test cases for 
`SubmitRequestTest` covering memory config parsing from YAML, JSON, and 
Properties format Application Conf
   
   ## Verification
   
   - All existing tests pass (12/12 in SubmitRequestTest)
   - New tests cover memory configs in YAML, JSON, and Properties formats


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to