88fantasy opened a new issue, #4491:
URL: https://github.com/apache/streampark/issues/4491

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/streampark/issues?q=is%3Aissue+label%3A%22bug%22)
 and found no similar issues referencing `FlinkAppCreateRequest`.
   
   ### Java Version
   
   Temurin 21.0.11 (console), built with Microsoft OpenJDK 11.0.28
   
   ### Scala Version
   
   2.12.x
   
   ### StreamPark Version
   
   3.0.0-SNAPSHOT (`dev` branch, commit `9ddda84c9`)
   
   ### Flink Version
   
   1.20.4 (official binary distribution, standalone/remote cluster)
   
   ### Deploy mode
   
   remote
   
   ### What happened
   
   Saving any Flink SQL application that has **already been started at least 
once** fails from the UI with:
   
   ```
   Flink sql is null, update flink sql job failed.
   ```
   
   Applications that have never been started are unaffected, because those take 
the candidate branch instead.
   
   `EditStreamPark.vue` sends `sqlId` with the update request, and 
`FlinkApplicationManageServiceImpl.updateFlinkSqlJob()` depends on 
`appParam.getSqlId()` in its else branch — but `FlinkAppCreateRequest` (which 
`FlinkAppUpdateRequest` extends) declares no `sqlId` field. 
`BeanUtils.copyProperties` silently skips what it cannot find, so the entity's 
`sqlId` is always `null` by the time the service reads it.
   
   This looks like a one-sided omission from the DTO refactor in `f89652b67`: 
`SparkAppCreateRequest` declares `sqlId`, and so does `FlinkAppResponse` — only 
the Flink request DTOs are missing it.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to