github-advanced-security[bot] commented on code in PR #4468:
URL: https://github.com/apache/streampark/pull/4468#discussion_r3698170793
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/config/SpringProperties.java:
##########
@@ -104,6 +104,16 @@
String userName = userConfig.getProperty("spring.datasource.username",
"admin");
String password = userConfig.getProperty("spring.datasource.password",
"streampark");
+ if ("admin".equals(userName) && "streampark".equals(password)) {
Review Comment:
## SonarCloud / Credentials should not be hard-coded
<!--SONAR_ISSUE_KEY:AZ_BQbAu1vMCp7SkqwW5-->'password' detected in this
expression, review this potentially hard-coded password. <p>See more on <a
href="https://sonarcloud.io/project/issues?id=apache_incubator-streampark&issues=AZ_BQbAu1vMCp7SkqwW5&open=AZ_BQbAu1vMCp7SkqwW5&pullRequest=4468";>SonarQube
Cloud</a></p>
[Show more
details](https://github.com/apache/streampark/security/code-scanning/270)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
