limc5462 commented on code in PR #4337:
URL: https://github.com/apache/streampark/pull/4337#discussion_r2986601455
##########
streampark-e2e/streampark-e2e-case/src/test/java/org/apache/streampark/e2e/pages/resource/ResourcePage.java:
##########
@@ -44,24 +45,28 @@ public ResourcePage(RemoteWebDriver driver) {
super(driver);
}
+ @SneakyThrows
public <T extends ResourcePage.Tab> T goToTab(Class<T> tab) {
if (tab == VariablesPage.class) {
new WebDriverWait(driver,
Constants.DEFAULT_WEBDRIVER_WAIT_DURATION)
.until(ExpectedConditions.elementToBeClickable(menuVariables));
+ Thread.sleep(Constants.DEFAULT_UI_ANIMATION_SLEEP_MILLISECONDS);
menuVariables.click();
Review Comment:
@wolfboys This sleep pattern (`@SneakyThrows` +
`Thread.sleep(DEFAULT_SLEEP_MILLISECONDS)`) is already used in 21 places across
the e2e module. My code follows the same convention — sleeping 2000ms after
clicking a dropdown to wait for options to render, identical to
ApplicationForm.flinkCluster() and UploadsPage. Modifying all existing
occurrences would be too invasive; I suggest keeping the current approach
consistent.
Like this
<img width="1572" height="1222" alt="image"
src="https://github.com/user-attachments/assets/733b74de-f903-491b-887c-7174f68fdef2";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
