Copilot commented on code in PR #4285:
URL: https://github.com/apache/streampark/pull/4285#discussion_r2335226188
##########
.github/workflows/docker-push.yml:
##########
@@ -18,12 +18,15 @@
name: "Build Docker Image"
on:
+ schedule:
+ - cron: '30 09 * * *'
+ timezone: 'Asia/Shanghai'
push:
branches:
- release-*
- release:
- types:
- - released
+ tags:
+ - 'v[2-9]+.[0-9]+.[0-9]+' # 匹配正式版本（如 v2.0.0）
+ - '!v[2-9]+.[0-9]+.[0-9]+-rc*' # 排除所有带 -rc 的版本
Review Comment:
[nitpick] The comments are in Chinese which may not be accessible to all
contributors. Consider using English comments for consistency: '# Match release
versions (e.g., v2.0.0)' and '# Exclude all versions with -rc suffix'.
##########
.github/workflows/docker-push.yml:
##########
@@ -18,12 +18,15 @@
name: "Build Docker Image"
on:
+ schedule:
+ - cron: '30 09 * * *'
+ timezone: 'Asia/Shanghai'
push:
branches:
- release-*
- release:
- types:
- - released
+ tags:
+ - 'v[2-9]+.[0-9]+.[0-9]+' # 匹配正式版本（如 v2.0.0）
+ - '!v[2-9]+.[0-9]+.[0-9]+-rc*' # 排除所有带 -rc 的版本
Review Comment:
The exclusion pattern using '!' prefix is not standard GitHub Actions syntax
for tag filtering. Tag filters work inclusively - only matching tags will
trigger the workflow. The exclusion pattern should be removed as it won't
function as intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
