wolfboys commented on code in PR #3989:
URL:
https://github.com/apache/incubator-streampark/pull/3989#discussion_r1727144108
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkAppHttpWatcher.java:
##########
@@ -575,6 +578,7 @@ and the status is not obtained this time (flink rest server
is closed),
if (trackingUrl != null &&
!trackingUrl.equals(application.getJobManagerUrl())) {
application.setJobManagerUrl(trackingUrl);
applicationService.updateJobManagerUrl(application.getId(),
trackingUrl);
+ applicationLogService.updateJobManagerUrl(application.getId(),
trackingUrl);
Review Comment:
Thanks for your contribution. I think the job history record should not be
modified. It is just an objective record of the job. The job instance recorded
in this table may have stopped running, so it is unreasonable to modify its
information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
