wolfboys commented on code in PR #3847:
URL:
https://github.com/apache/incubator-streampark/pull/3847#discussion_r1670273747
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SettingServiceImpl.java:
##########
@@ -60,6 +62,9 @@ public class SettingServiceImpl extends
ServiceImpl<SettingMapper, Setting>
private final Setting emptySetting = new Setting();
+ @Autowired
+ SettingMapper settingMapper;
Review Comment:
No need to define this mapper
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SettingServiceImpl.java:
##########
@@ -100,7 +105,31 @@ public MavenConfig getMavenConfig() {
@Override
public DockerConfig getDockerConfig() {
- return DockerConfig.fromSetting();
+ List<Setting> settingList =
settingMapper.querySettingByKeys(Arrays.asList(
Review Comment:
baseMapper.querySettingByKeys(xxx)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
