dyccode commented on code in PR #3796:
URL:
https://github.com/apache/incubator-streampark/pull/3796#discussion_r1651027603
##########
streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/trait/FlinkClientTrait.scala:
##########
@@ -539,10 +539,6 @@ trait FlinkClientTrait extends Logger {
case (false, false) =>
client.cancel(jobID).get()
null
- case (true, false) =>
- clientWrapper
- .cancelWithSavepoint(jobID, savePointDir, cancelRequest.nativeFormat)
Review Comment:
According to Flink documentation,using `cancel` command to stop a job with
savepoint is deprecated.Use the `stop` action instead. It is a more graceful
way of stopping a running streaming job as the stop flows from source to sink.
When the user requests to stop a job, all sources will be requested to send the
last checkpoint barrier that will trigger a savepoint, and after the successful
completion of that savepoint, they will finish by calling their `cancel()`
method.
I have tested yarn-perjob and yarn-session, they can be stopped normally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
