wolfboys commented on code in PR #3006:
URL:
https://github.com/apache/incubator-streampark/pull/3006#discussion_r1313158187
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/security/impl/AuthenticatorImpl.java:
##########
@@ -59,9 +59,11 @@ public User authenticate(String username, String password,
String loginType) thr
private User passwordAuthenticate(String username, String password) {
User user = usersService.findByName(username);
- if (user == null || user.getLoginType() != LoginType.PASSWORD) {
- throw new ApiAlertException(
- String.format("user [%s] does not exist or can not login with
PASSWORD", username));
+ if (user == null) {
Review Comment:
> The `passwordAuthenticate` is used to authenticate the password login,
where have to throw error when user doesn't exist, while `ldapAuthenticate` is
used for ldap login, and we already have that logic to handle the new user add
scenario. Thanks.
Thank you for your clarification. looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
