wuchunfu commented on code in PR #2994:
URL:
https://github.com/apache/incubator-streampark/pull/2994#discussion_r1312912321
##########
streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/impl/KubernetesNativeApplicationClient.scala:
##########
@@ -59,17 +64,18 @@ object KubernetesNativeApplicationClient extends
KubernetesNativeClientTrait {
flinkConfig.safeSet(KubernetesConfigOptions.CONTAINER_IMAGE,
buildResult.flinkImageTag)
// retrieve k8s cluster and submit flink job on application mode
- var clusterDescriptor: KubernetesClusterDescriptor = null
var clusterClient: ClusterClient[String] = null
try {
- val (descriptor, clusterSpecification) =
getK8sClusterDescriptorAndSpecification(flinkConfig)
- clusterDescriptor = descriptor
- val applicationConfig =
ApplicationConfiguration.fromConfiguration(flinkConfig)
- clusterClient = clusterDescriptor
- .deployApplicationCluster(clusterSpecification, applicationConfig)
- .getClusterClient
-
+// val (descriptor, clusterSpecification) =
getK8sClusterDescriptorAndSpecification(flinkConfig)
+// clusterDescriptor = descriptor
+//
+// val applicationConfig =
ApplicationConfiguration.fromConfiguration(flinkConfig)
+// clusterClient = clusterDescriptor
+// .deployApplicationCluster(clusterSpecification, applicationConfig)
+// .getClusterClient
Review Comment:
@caicancai If you want to modify the commented out code later, it is
recommended to add a todo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
