epugh commented on PR #4233: URL: https://github.com/apache/solr/pull/4233#issuecomment-4197283180
> Actually, my warning-log in branch_10x ended up looking pretty general purpose. Essentially, EnvUtils now has a list of removed properties and the 'init' in that class will check to see if any of those "removed props" are currently set. If so, a warning is logged. > > > > > > If we like that general approach, we can bring it forward to 'main'. Right now that bit of code is only on branch_10x, which feels a little weird. > > > > Here's the commit, for reference: https://github.com/apache/solr/commit/121f8ba25f380672bcb902c931415383fea55c46 I was hoping you used EnvUtils and I think this is a great way of handling more generically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
