dsmiley commented on code in PR #4237: URL: https://github.com/apache/solr/pull/4237#discussion_r3030239748
########## changelog/unreleased/SOLR-18176-shardhandler-bottleneck.yml: ########## @@ -1,7 +1,9 @@ -title: Increased query throughput by removing a call to ZooKeeper for cluster state that should have been cached +title: Fix query throughput bottleneck caused by uncached ZooKeeper get calls for queries with explicit 'collection' parameter Review Comment: It's not obvious but we're permitted to put multiple sentences here. I think the sentence you replaced was great as it was. Adding a second sentence clarifying the scope of impact (i.e. under what circumstances this was a problem) is needed too. "queries with an explicit 'collection' parameter" -- uh, this is news to me. Perhaps say (if true): "Happens when Solr does distributed-search over multiple collections, and when the coordinator has no local replica for some of them." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
