[ 
https://issues.apache.org/jira/browse/SOLR-18130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070413#comment-18070413
 ] 

Vladimir Vyatkin commented on SOLR-18130:
-----------------------------------------

I implements CloudSolrClient.Builder with universal connection string support 
and replace it in SolrClientCache

WIP PR: [https://github.com/apache/solr/pull/4260]

 I'm currently exploring the possibility of adding full support for both 
connection types to solrj-streaming without breaking backward compatibility. It 
should work with my changes for both connection types now, but all the 
variables and parameters are called zkHost. I propose adding a second 
parameter, "connectionString," and considering the possibility of also 
specifying zkHost to maintain backward compatibility.

 

> CloudSolrStream should not depend on ZooKeeper
> ----------------------------------------------
>
>                 Key: SOLR-18130
>                 URL: https://issues.apache.org/jira/browse/SOLR-18130
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ, streaming expressions
>            Reporter: David Smiley
>            Priority: Major
>              Labels: newdev, pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the SolrJ streaming expressions module, CloudSolrStream depends on 
> ZooKeeper, and thus so does its subclasses (DrillStream, TopicStream, 
> ShuffleStream, ParallelStream).  It's a runtime dependency, triggered by a 
> "zkHost" parameter that's supplied to {{SolrClientCache#getCloudSolrClient}} 
> that uses {{CloudSolrClient.Builder}} that uses reflection to try to load 
> {{ZkClientClusterStateProvider}}.
> I propose renaming these parameters in the module from zkHost to maybe 
> "quorumHosts" that could either be list of Solr HTTP (when it starts with 
> "http:" or "https:") or ZK if not.   This should bring about a new 
> well-deserved constructor to CloudSolrClient.Builder to parse a string, as 
> it's not a matter specific to streaming expressions.  This would be very 
> convenient to callers I've seen elsewhere.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to