james-willis commented on code in PR #749:
URL: https://github.com/apache/sedona-db/pull/749#discussion_r3228748448
##########
rust/sedona-raster/Cargo.toml:
##########
@@ -40,3 +40,4 @@ sedona-schema = { workspace = true }
[dev-dependencies]
sedona-testing = { workspace = true }
approx = { workspace = true }
+arrow-ipc = { workspace = true }
Review Comment:
yes, we use it in the tests
##########
rust/sedona-schema/src/raster.rs:
##########
@@ -16,34 +16,54 @@
// under the License.
use arrow_schema::{DataType, Field, FieldRef, Fields};
-/// Schema for storing raster data in Apache Arrow format.
-/// Utilizing nested structs and lists to represent raster metadata and bands.
+/// Schema for storing N-dimensional raster data in Apache Arrow format.
+///
+/// Each raster has a CRS, an affine transform, a list of spatial dimension
+/// names (`spatial_dims`) and sizes (`spatial_shape`), and a list of bands.
+/// Each band is an N-D chunk with named dimensions, a `source_shape`
+/// describing the natural extent of its underlying buffer, and a `view`
+/// describing the visible region of that buffer.
+///
+/// `spatial_dims` + `spatial_shape` are the raster-level source of truth for
+/// the spatial grid — today length 2 (`["x","y"]`, `[width, height]`),
+/// Z-ready for a future 3D phase. All bands must contain every name in
+/// `spatial_dims` in their own `dim_names`, with the band's *visible* size
+/// for that dim matching `spatial_shape`.
+///
+/// Legacy 2D rasters are represented as bands with `dim_names=["y","x"]` and
+/// `source_shape=[height, width]`.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
