paleolimbot commented on code in PR #816:
URL: https://github.com/apache/sedona-db/pull/816#discussion_r3198645781
##########
c/sedona-s2geography/src/kernels.rs:
##########
@@ -46,7 +53,202 @@ pub fn s2_scalar_kernels() -> Result<Vec<(String,
ScalarKernelRef)>> {
Arc::new(imported_kernel) as ScalarKernelRef,
))
})
- .collect()
+ .collect::<Result<Vec<_>>>()?;
+
+ // A few functions need explicit NULL type matching. This is mostly a
DataFusion
+ // thing (NULL can happen when binding parameters) so we handle it here
and not
+ // in s2geography.
+
+ // Binary (geography, geography) -> Boolean
+ let binary_bool_fns = [
+ "st_contains",
+ "st_disjoint",
+ "st_equals",
+ "st_intersects",
+ "st_within",
+ ];
Review Comment:
This was a code change...I added kernels to match things like
`st_intersects(geography, NULL)`. This is mostly for parameter binding...params
are inserted into a plan as a Null type and the plan is validated before it's
replace with something of the correct type.
##########
c/sedona-s2geography/s2geography:
##########
Review Comment:
I fixed a few issues in s2geography and updated the submodule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
