jiayuasu commented on PR #2889: URL: https://github.com/apache/sedona/pull/2889#issuecomment-4363104893
Pushed `856d17a081`. | Review point | Action | |---|---| | Intro lists `concave_hull` / `to_crs` / `voronoi_polygons` not used | Trimmed to the methods actually called: `convex_hull`, `clip_by_rect`, `total_bounds`, `to_geopandas`. Voronoi is now described as the SQL-fallback path it actually is. | | `clip_by_rect` is 1.9-only — make version requirement explicit | Added `**Requires Sedona ≥ 1.9.0.**` line to the intro. | | Section 7 says "African capitals" but uses `ST_Centroid(geometry)` of country polygons | Reworded to "African countries' centroids closest to (0°N, 0°E)". The data only contains country polygons, so centroid-of-country is the correct framing. | | Unused `from shapely.geometry import shape` | Removed. | | Suspected `IndentationError` on the SedonaContext line | The `sedona = SedonaContext.create(config)` line is at column 0 in the cell source (not indented inside the `(...)` block). The notebook executes cleanly end-to-end — verified by re-running it through the local mirror of `docker/test-notebooks.sh` (matched docker stack: Python 3.10, pyspark 4.0.1, sedona 1.9.0, JDK 17, `local[*]`, `DRIVER_MEM=4g`). Result: `PASS 05-geopandas-on-spark 21s elapsed`. No code change. | Re-verified end-to-end after every edit; output unchanged (54 African countries, 54 Voronoi cells before and after `clip_by_rect`, São Tomé closest to (0,0) at 750.1 km). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
