paleolimbot commented on code in PR #799:
URL: https://github.com/apache/sedona-db/pull/799#discussion_r3168364977
##########
c/sedona-libgpuspatial/src/lib.rs:
##########
@@ -113,9 +112,10 @@ mod sys {
/// Inserts a batch of bounding boxes into the index.
/// Each rectangle is represented as a `Rect<f32>` with minimum and
maximum x and y coordinates.
/// This method accumulates these rectangles until `finish_building`
is called to finalize the index.
- /// The method can be called multiple times to insert data in batches
before finalizing.
- pub fn push_build(&mut self, rects: &[Rect<f32>]) -> Result<()> {
- // Re-interpreting Rect<f32> as flat f32 array (xmin, ymin, xmax,
ymax)
+ /// The method can be called multiple times to insert data in batches
before finalizing. The values
+ /// in rects are ordered (xmin, ymin, xmax, ymax).
+ pub fn push_build(&mut self, rects: &[(f32, f32, f32, f32)]) ->
Result<()> {
+ // Re-interpreting rects as a flat f32 array (xmin, ymin, xmax,
ymax)
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
