zhangfengcdt commented on PR #790:
URL: https://github.com/apache/sedona-db/pull/790#issuecomment-4345882700

   Thanks for the contribution! Could you please clarify the use cases you want 
to support by adding this st function? Also,
   
   1. The UDF needs to be registered in rust/sedona-functions/src/register.rs 
inside register_scalar_udfs — otherwise it's not callable from SQL.
   2. GEOS-backed kernels in this project live in the c/sedona-geos crate (see 
c/sedona-geos/src/distance.rs) and use GeosExecutor. Could you move the 
implementation there and drop the new geos dep from 
rust/sedona-functions/Cargo.toml?
   
   Also, please add the Apache license header to any new files. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to