jiayuasu commented on issue #2861: URL: https://github.com/apache/sedona/issues/2861#issuecomment-4322816694
Good point — the docs site already organizes functions into well-defined categories at `/latest/api/sql/Geometry-Functions/` and the corresponding raster pages. Aligning `Catalog.scala` with the existing docs taxonomy is much better than inventing new category names. Updated proposal: ## Docs-aligned categories **ST_ (vector) functions** — 17 categories matching docs: | val name | docs page | |----------|-----------| | `geometryConstructorExprs` | Geometry-Constructors | | `geometryAccessorExprs` | Geometry-Accessors | | `geometryEditorExprs` | Geometry-Editors | | `geometryOutputExprs` | Geometry-Output | | `geometryProcessingExprs` | Geometry-Processing | | `geometryValidationExprs` | Geometry-Validation | | `predicateExprs` | Predicates | | `measurementExprs` | Measurement-Functions | | `overlayExprs` | Overlay-Functions | | `affineTransformationExprs` | Affine-Transformations | | `linearReferencingExprs` | Linear-Referencing | | `boundingBoxExprs` | Bounding-Box-Functions | | `spatialReferenceSystemExprs` | Spatial-Reference-System | | `spatialIndexingExprs` | Spatial-Indexing | | `clusteringExprs` | Clustering-Functions (registered via `geoStatsFunctions()`) | | `spatialStatisticsExprs` | Spatial-Statistics (registered via `geoStatsFunctions()`) | | `addressExprs` | Address-Functions | **ST_Geog (geography) functions** — match the `docs/api/sql/geography/` subfolder: | val name | description | |----------|-------------| | `geographyExprs` | ST_GeogFromText, ST_GeogToGeometry, ST_GeomToGeography, etc. | **RS_ (raster) functions** — match the docs structure: | val name | docs page | |----------|-----------| | `rasterConstructorExprs` | Raster-Constructors | | `rasterAccessorExprs` | Raster-Accessors | | `rasterBandAccessorExprs` | Raster-Band-Accessors | | `rasterOperatorExprs` | Raster-Operators | | `rasterOutputExprs` | Raster-Output | | `rasterPredicateExprs` | Raster-Predicates | | `rasterGeometryExprs` | Raster-Geometry-Functions | | `pixelExprs` | Pixel-Functions | | `mapAlgebraExprs` | Map-Algebra-Operators | | `rasterTileExprs` | Raster-Tiles | **Aggregate** functions stay in `aggregateExpressions` (different registration path), matching the Aggregate-Functions / Raster-Aggregate-Functions docs pages. ## Benefit of docs alignment - Single canonical taxonomy across docs and code — contributors who look up a function in the docs find the same category name in `Catalog.scala`. - No bikeshedding on category names; we just borrow the ones the project already maintains. - If a category gets a docs page later (e.g., a new RS_ category), the corresponding val gets created in lockstep. Will revise the PR to use this taxonomy. Any objections to this naming or grouping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
