Copilot commented on code in PR #2853:
URL: https://github.com/apache/sedona/pull/2853#discussion_r3125457265
##########
spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala:
##########
@@ -273,7 +273,9 @@ private[apache] case class ST_Length2D(inputExpressions:
Seq[Expression])
* @param inputExpressions
*/
private[apache] case class ST_Area(inputExpressions: Seq[Expression])
- extends InferredExpression(Functions.area _) {
+ extends InferredExpression(
+ inferrableFunction1(Functions.area),
+ inferrableFunction1(org.apache.sedona.common.geography.Functions.area)) {
Review Comment:
The Scaladoc above `ST_Area` now says it returns the area measurement of a
Geometry, but this expression is now dual-dispatching to Geography as well
(geodesic area in m²). Update the comment to reflect both input types/semantics
so callers don’t assume planar Geometry-only behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
