Copilot commented on code in PR #2850:
URL: https://github.com/apache/sedona/pull/2850#discussion_r3125217336
##########
common/src/test/java/org/apache/sedona/common/Geography/FunctionTest.java:
##########
@@ -144,6 +144,35 @@ public void nPoints_polygon() throws ParseException {
assertEquals(5, Functions.nPoints(g));
}
+ @Test
+ public void geometryType_point() throws ParseException {
+ Geography g = Constructors.geogFromWKT("POINT (1 2)", 4326);
+ assertEquals("ST_Point", Functions.geometryType(g));
+ }
+
+ @Test
+ public void geometryType_linestring() throws ParseException {
+ Geography g = Constructors.geogFromWKT("LINESTRING (0 0, 1 1, 2 2)", 4326);
+ assertEquals("ST_LineString", Functions.geometryType(g));
+ }
+
+ @Test
+ public void geometryType_polygon() throws ParseException {
+ Geography g = Constructors.geogFromWKT("POLYGON ((0 0, 1 0, 1 1, 0 1, 0
0))", 4326);
+ assertEquals("ST_Polygon", Functions.geometryType(g));
+ }
+
+ @Test
+ public void geometryType_multiPoint() throws ParseException {
Review Comment:
Test method name `geometryType_multiPoint` uses camelCase after the
underscore, while the surrounding tests consistently use snake_case (e.g.,
`nPoints_linestring`, `geometryType_linestring`). Rename to
`geometryType_multipoint` (or similar) to keep naming consistent and make test
discovery/searching predictable.
```suggestion
public void geometryType_multipoint() throws ParseException {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
