petern48 commented on code in PR #741:
URL: https://github.com/apache/sedona-db/pull/741#discussion_r3041158662
##########
python/sedonadb/tests/functions/test_predicates.py:
##########
@@ -495,3 +495,55 @@ def test_st_relate(eng, geom1, geom2, expected):
f"SELECT ST_Relate({geom_or_null(geom1)}, {geom_or_null(geom2)})",
expected,
)
+
+
[email protected]("eng", [SedonaDB, PostGIS])
[email protected](
+ ("geom1", "geom2", "pattern", "expected"),
+ [
+ (None, None, None, None),
+ ("POINT (0 0)", None, "FF0FFF0F2", None),
+ (None, "POINT (0 0)", "FF0FFF0F2", None),
Review Comment:
Actually,
https://github.com/apache/sedona-db/pull/741/changes/516ce5f68e78ed47220167a254afc86e4fa2aa63
only restored the test to `test_st_relate`, which does address
https://github.com/apache/sedona-db/pull/741#discussion_r3036168644, but does
not address this current comment. I requested to restore both. Could you please
restore it to `test_st_relate_pattern` as well? This is important because we
technically still haven't seen proof that this is working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
